-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oy2 28896 #681
Oy2 28896 #681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work going through all of these and working with Erika to ensure the correct toAddresses match the confluence
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job..... please make sure to 'squash' when merging into master
* made minor text changes, have not tested yet * compared and made the same as the confluence where possible, added the text files, also did a minor rearrange so that it follows cms -> state pattern * merged master & changed email for testing purposes * trying this to get emails to my personal * added missing appK title key for Ammendment title * added a switch just for appK title * changing the appK title logic because I broke it * removed whole appK case bc I think that broke it? * removed my email that was there for testing because I dont need it anymore * fixed extra tag and changed to a value we have * putting appKtitle back * added appKtitle to dataLIst * lowercase K for appk and removed my email * cleaned up a little * changed intial waiver to actionType variable * fixed minor text change missing the variable actionType and matched text for appK * corrected email template text for temporary-extension-state template according to templates confluence page * fixed text for waiver withdraw state email * fixed text on withdraw-rai-1915b-state * added missing TE type variable * oy2-28874: added other text for empty summary * removed duplicate lines as per Hannas Jira comment * Oy2 28892 - fix 1915(c) emails (#692) * make waiver withdraw and respond to rai generic across 1915b and 1915c * remove unused var causing cms withdraw emails to fail * Oy2 28896 (#681) * added cpoc to ToAddresses for waiver/medecaid related email templates * correct email templates toAddresses as per Email Notification Confluence Co-authored-by: Andie Swift <[email protected]> * merged main * deleted src to match master * withdraw chip rai - added the cms reciepents to datalist & added cognito to lookup list to fix issue where no email isnt being sent --------- Co-authored-by: Benjamin Paige <[email protected]> Co-authored-by: Alex Youssefinia <[email protected]> Co-authored-by: bflynn-cms <[email protected]>
As per the Email Notifications Confluence, There Are some package submissions for medicaid spa/waivers that do not have CPOC under the “To” address field. I have listed them here:
Initial Medicaid Spa Submission
Withdrawl Medicaid Spa Package
New Waiver 1915b submission
New Waiver 1915c submission
Temporary Extensions 1915b/1915c
After discussion with @Erika Durant we have decided to use the confluence as higher authority! While Going through the email templates, we noticed that some corrections can be made to better match the Email Confluence. I have them listed here:
added DMCO to addresses for Withdraw RAI response 1915b
Removed OSG from new submission Chip SPA
Removed OSG, added SRT & CPOC to "Respond to Chip Spa RAI"
Please see the following diff for clarification:
Comparing oy2-28891...oy2-28896 · Enterprise-CMCS/macpro-mako
Please advise if the confluence is not up to date for any of the above scenarios.
Also please note that I did not notice an email template for “Subsequent Submission for Medicaid SPA” listed on the confluence. Should we add this template? @brandon Flynn